[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/15] hw/mips/gt64xxx_pci: Convert gt64120_rese
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-devel] [PATCH 07/15] hw/mips/gt64xxx_pci: Convert gt64120_reset() function into Device reset method |
Date: |
Tue, 2 Oct 2018 17:49:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/2/18 12:09 AM, Philippe Mathieu-Daudé wrote:
> Convert the gt64120_reset() function into a proper Device reset method.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Thanks,
C.
> ---
> hw/mips/gt64xxx_pci.c | 17 +++--------------
> 1 file changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c
> index 24ad0ad024..dcd1a66329 100644
> --- a/hw/mips/gt64xxx_pci.c
> +++ b/hw/mips/gt64xxx_pci.c
> @@ -992,9 +992,9 @@ static void gt64120_pci_set_irq(void *opaque, int
> irq_num, int level)
> }
>
>
> -static void gt64120_reset(void *opaque)
> +static void gt64120_reset(DeviceState *dev)
> {
> - GT64120State *s = opaque;
> + GT64120State *s = GT64120_PCI_HOST_BRIDGE(dev);
>
> /* FIXME: Malta specific hw assumptions ahead */
>
> @@ -1184,16 +1184,6 @@ PCIBus *gt64120_register(qemu_irq *pic)
> return phb->bus;
> }
>
> -static int gt64120_init(SysBusDevice *dev)
> -{
> - GT64120State *s;
> -
> - s = GT64120_PCI_HOST_BRIDGE(dev);
> -
> - qemu_register_reset(gt64120_reset, s);
> - return 0;
> -}
> -
> static void gt64120_pci_realize(PCIDevice *d, Error **errp)
> {
> /* FIXME: Malta specific hw assumptions ahead */
> @@ -1241,9 +1231,8 @@ static const TypeInfo gt64120_pci_info = {
> static void gt64120_class_init(ObjectClass *klass, void *data)
> {
> DeviceClass *dc = DEVICE_CLASS(klass);
> - SysBusDeviceClass *sdc = SYS_BUS_DEVICE_CLASS(klass);
>
> - sdc->init = gt64120_init;
> + dc->reset = gt64120_reset;
> dc->vmsd = &vmstate_gt64120;
> }
>
>
[Qemu-devel] [PATCH 07/15] hw/mips/gt64xxx_pci: Convert gt64120_reset() function into Device reset method, Philippe Mathieu-Daudé, 2018/10/01
[Qemu-devel] [PATCH 03/15] hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init, Philippe Mathieu-Daudé, 2018/10/01
[Qemu-devel] [PATCH 02/15] hw/timer/sun4v-rtc: Convert from DPRINTF() macro to trace events, Philippe Mathieu-Daudé, 2018/10/01
[Qemu-devel] [PATCH 01/15] trace-events: Fix copy/paste typo, Philippe Mathieu-Daudé, 2018/10/01
[Qemu-devel] [PATCH 12/15] hw/core: Remove the 'empty_slot' device, Philippe Mathieu-Daudé, 2018/10/01