[Qemu-commits] [qemu/qemu] c91a2a: target/s390x/excp_helper: Remove DPRINTF() macro

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c91a2a21dffa4cd8c04b0f6ed376cfb1d4d182c9
      
https://github.com/qemu/qemu/commit/c91a2a21dffa4cd8c04b0f6ed376cfb1d4d182c9
  Author: Thomas Huth <address@hidden>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M target/s390x/excp_helper.c

  Log Message:
  -----------
  target/s390x/excp_helper: Remove DPRINTF() macro

Debug macros that are disabled by default should be avoided (since the
code bit-rots quite easily). Thus turn these debug prints into proper
qemu_log_mask(CPU_LOG_xxx, ...) statements instead. The DPRINTF statements
in do_[ext|io|mchk]_interrupt can even be removed completely since we can
log the information in a central place, s390_cpu_do_interrupt, instead.

Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 8f3cd250a897213d39e621e3d824507b48158d42
      
https://github.com/qemu/qemu/commit/8f3cd250a897213d39e621e3d824507b48158d42
  Author: Cornelia Huck <address@hidden>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M include/standard-headers/linux/input.h
    M linux-headers/asm-arm/kvm.h
    M linux-headers/asm-arm64/kvm.h
    M linux-headers/asm-s390/kvm.h
    M linux-headers/asm-x86/kvm.h
    M linux-headers/linux/kvm.h
    M linux-headers/linux/vfio.h
    M linux-headers/linux/vhost.h

  Log Message:
  -----------
  linux-headers: update

Update to kvm/next commit dd5bd0a65ff6 ("Merge tag 'kvm-s390-next-4.20-1'
of git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux into HEAD")

Signed-off-by: Cornelia Huck <address@hidden>


  Commit: c5cd17afddda89376712b315a41ede96b034e4c2
      
https://github.com/qemu/qemu/commit/c5cd17afddda89376712b315a41ede96b034e4c2
  Author: Tony Krowiak <address@hidden>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M target/s390x/cpu_features.c
    M target/s390x/cpu_features_def.h
    M target/s390x/cpu_models.c
    M target/s390x/gen-features.c

  Log Message:
  -----------
  s390x/cpumodel: Set up CPU model for AP device support

A new CPU model feature and two new CPU model facilities are
introduced to support AP devices for a KVM guest.

CPU model features:

1. The S390_FEAT_AP CPU model feature indicates whether AP
   instructions are available to the guest. This feature will
   be enabled only if the AP instructions are available on the
   linux host as determined by the availability of the
   KVM_S390_VM_CRYPTO_ENABLE_APIE VM attribute which is exposed
   by KVM only if the AP instructions are available on the
   host.

   This feature must be turned on from userspace to execute AP
   instructions on the KVM guest. The QEMU command line to turn
   this feature on looks something like this:

        qemu-system-s390x ... -cpu xxx,ap=on ...

   This feature will be supported for zEC12 and newer CPU models.
   The feature will not be supported for older models because
   there are few older systems on which to test and the older
   crypto cards will be going out of service in the relatively
   near future.

CPU model facilities:

1. The S390_FEAT_AP_QUERY_CONFIG_INFO feature indicates whether the
   AP Query Configuration Information (QCI) facility is available
   to the guest as determined by whether the facility is available
   on the host. This feature will be exposed by KVM only if the
   QCI facility is installed on the host.

2. The S390_FEAT_AP_FACILITY_TEST feature indicates whether the AP
   Facility Test (APFT) facility is available to the guest as
   determined by whether the facility is available on the host.
   This feature will be exposed by KVM only if APFT is installed
   on the host.

Signed-off-by: Tony Krowiak <address@hidden>
Tested-by: Pierre Morel <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Reviewed-by: Halil Pasic <address@hidden>
Reviewed-by: Christian Borntraeger <address@hidden>
Tested-by: Christian Borntraeger <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 1d7db85b61cb9888b8ed8c8923343b468405b7a0
      
https://github.com/qemu/qemu/commit/1d7db85b61cb9888b8ed8c8923343b468405b7a0
  Author: Tony Krowiak <address@hidden>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M target/s390x/kvm.c

  Log Message:
  -----------
  s390x/kvm: enable AP instruction interpretation for guest

Let's use the KVM_SET_DEVICE_ATTR ioctl to enable hardware
interpretation of AP instructions executed on the guest.
If the S390_FEAT_AP feature is switched on for the guest,
AP instructions must be interpreted by default; otherwise,
they will be intercepted.

This attribute setting may be overridden by a device. For example,
a device may want to provide AP instructions to the guest (i.e.,
S390_FEAT_AP turned on), but it may want to emulate them. In this
case, the AP instructions executed on the guest must be
intercepted; so when the device is realized, it must disable
interpretation.

Signed-off-by: Tony Krowiak <address@hidden>
Tested-by: Pierre Morel <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Christian Borntraeger <address@hidden>
Acked-by: Halil Pasic <address@hidden>
Tested-by: Christian Borntraeger <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: a51b31535a8ec13997de29b357f7cc1dcd8a7f9c
      
https://github.com/qemu/qemu/commit/a51b31535a8ec13997de29b357f7cc1dcd8a7f9c
  Author: Tony Krowiak <address@hidden>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M MAINTAINERS
    M hw/s390x/Makefile.objs
    A hw/s390x/ap-bridge.c
    A hw/s390x/ap-device.c
    M hw/s390x/s390-virtio-ccw.c
    A include/hw/s390x/ap-bridge.h
    A include/hw/s390x/ap-device.h

  Log Message:
  -----------
  s390x/ap: base Adjunct Processor (AP) object model

Introduces the base object model for virtualizing AP devices.

Signed-off-by: Tony Krowiak <address@hidden>
Tested-by: Pierre Morel <address@hidden>
Acked-by: David Hildenbrand <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Halil Pasic <address@hidden>
Tested-by: Christian Borntraeger <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 2fe2942cd6ddad8ddd40fe5d16d67599c28959d7
      
https://github.com/qemu/qemu/commit/2fe2942cd6ddad8ddd40fe5d16d67599c28959d7
  Author: Tony Krowiak <address@hidden>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M MAINTAINERS
    M default-configs/s390x-softmmu.mak
    M hw/vfio/Makefile.objs
    A hw/vfio/ap.c
    M include/hw/vfio/vfio-common.h

  Log Message:
  -----------
  s390x/vfio: ap: Introduce VFIO AP device

Introduces a VFIO based AP device. The device is defined via
the QEMU command line by specifying:

    -device vfio-ap,sysfsdev=<path-to-mediated-matrix-device>

There may be only one vfio-ap device configured for a guest.

The mediated matrix device is created by the VFIO AP device
driver by writing a UUID to a sysfs attribute file (see
docs/vfio-ap.txt). The mediated matrix device will be named
after the UUID. Symbolic links to the $uuid are created in
many places, so the path to the mediated matrix device $uuid
can be specified in any of the following ways:

/sys/devices/vfio_ap/matrix/$uuid
/sys/devices/vfio_ap/matrix/mdev_supported_types/vfio_ap-passthrough/devices/$uuid
/sys/bus/mdev/devices/$uuid
/sys/bus/mdev/drivers/vfio_mdev/$uuid

When the vfio-ap device is realized, it acquires and opens the
VFIO iommu group to which the mediated matrix device is
bound. This causes a VFIO group notification event to be
signaled. The vfio_ap device driver's group notification
handler will get called at which time the device driver
will configure the the AP devices to which the guest will
be granted access.

Signed-off-by: Tony Krowiak <address@hidden>
Tested-by: Pierre Morel <address@hidden>
Acked-by: Halil Pasic <address@hidden>
Tested-by: Pierre Morel <address@hidden>
Tested-by: Christian Borntraeger <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
[CH: added missing g_free and device category]
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 694a8d703bfe06226a0574f5ec4af17a2b7060ef
      
https://github.com/qemu/qemu/commit/694a8d703bfe06226a0574f5ec4af17a2b7060ef
  Author: Tony Krowiak <address@hidden>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M MAINTAINERS
    A docs/vfio-ap.txt

  Log Message:
  -----------
  s390: doc: detailed specifications for AP virtualization

This patch provides documentation describing the AP architecture and
design concepts behind the virtualization of AP devices. It also
includes an example of how to configure AP devices for exclusive
use of KVM guests.

Signed-off-by: Tony Krowiak <address@hidden>
Reviewed-by: Pierre Morel <address@hidden>
Tested-by: Pierre Morel <address@hidden>
Tested-by: Christian Borntraeger <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 0161215d435ef5680c4623bcbdfe89ce5b35cf42
      
https://github.com/qemu/qemu/commit/0161215d435ef5680c4623bcbdfe89ce5b35cf42
  Author: Thomas Huth <address@hidden>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M hw/s390x/Makefile.objs

  Log Message:
  -----------
  hw/s390x: Include the tod-qemu also for builds with --disable-tcg

The device is required for running qtests, see hw/s390x/tod.c:

void s390_init_tod(void)
{
    Object *obj;

    if (kvm_enabled()) {
  obj = object_new(TYPE_KVM_S390_TOD);
    } else {
  obj = object_new(TYPE_QEMU_S390_TOD);
    }
    [...]
  }

During qtests, we're running without kvm, so TYPE_QEMU_S390_TOD is
required to avoid that QEMU aborts here.

Fixes: 8046f374a6 ("s390x/tod: factor out TOD into separate device")
Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 69ac8c4cb93f2685839ff7b857cef306b388ff3c
      
https://github.com/qemu/qemu/commit/69ac8c4cb93f2685839ff7b857cef306b388ff3c
  Author: Peter Maydell <address@hidden>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M MAINTAINERS
    M default-configs/s390x-softmmu.mak
    A docs/vfio-ap.txt
    M hw/s390x/Makefile.objs
    A hw/s390x/ap-bridge.c
    A hw/s390x/ap-device.c
    M hw/s390x/s390-virtio-ccw.c
    M hw/vfio/Makefile.objs
    A hw/vfio/ap.c
    A include/hw/s390x/ap-bridge.h
    A include/hw/s390x/ap-device.h
    M include/hw/vfio/vfio-common.h
    M include/standard-headers/linux/input.h
    M linux-headers/asm-arm/kvm.h
    M linux-headers/asm-arm64/kvm.h
    M linux-headers/asm-s390/kvm.h
    M linux-headers/asm-x86/kvm.h
    M linux-headers/linux/kvm.h
    M linux-headers/linux/vfio.h
    M linux-headers/linux/vhost.h
    M target/s390x/cpu_features.c
    M target/s390x/cpu_features_def.h
    M target/s390x/cpu_models.c
    M target/s390x/excp_helper.c
    M target/s390x/gen-features.c
    M target/s390x/kvm.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20181012' into staging

More s390x updates:
- introduce support for vfio-ap (s390 crypto devices), including a
  Linux headers update to get the new interfaces
- the usual fixing + cleanup

# gpg: Signature made Fri 12 Oct 2018 10:54:38 BST
# gpg:                using RSA key DECF6B93C6F02FAF
# gpg: Good signature from "Cornelia Huck <address@hidden>"
# gpg:                 aka "Cornelia Huck <address@hidden>"
# gpg:                 aka "Cornelia Huck <address@hidden>"
# gpg:                 aka "Cornelia Huck <address@hidden>"
# gpg:                 aka "Cornelia Huck <address@hidden>"
# Primary key fingerprint: C3D0 D66D C362 4FF6 A8C0  18CE DECF 6B93 C6F0 2FAF

* remotes/cohuck/tags/s390x-20181012:
  hw/s390x: Include the tod-qemu also for builds with --disable-tcg
  s390: doc: detailed specifications for AP virtualization
  s390x/vfio: ap: Introduce VFIO AP device
  s390x/ap: base Adjunct Processor (AP) object model
  s390x/kvm: enable AP instruction interpretation for guest
  s390x/cpumodel: Set up CPU model for AP device support
  linux-headers: update
  target/s390x/excp_helper: Remove DPRINTF() macro

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/c7f79d678f8c...69ac8c4cb93f
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.