[Qemu-commits] [qemu/qemu] 14a2d1: iothread: fix crash with invalid properties

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 14a2d11825ddc37d6547a80704ae6450e9e376c7
      
https://github.com/qemu/qemu/commit/14a2d11825ddc37d6547a80704ae6450e9e376c7
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M iothread.c

  Log Message:
  -----------
  iothread: fix crash with invalid properties

-object iothread,id=foo,? will crash qemu:

qemu-system-x86_64:qemu-thread-posix.c:128: qemu_cond_destroy: Assertion 
`cond->initialized' failed.

Use thread_id != -1 to check if iothread_complete() finished
successfully and the mutex/cond have been initialized.

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 6388147296cd4c841a7d4409ba622c200332a8c7
      
https://github.com/qemu/qemu/commit/6388147296cd4c841a7d4409ba622c200332a8c7
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M block/nvme.c

  Log Message:
  -----------
  nvme: correct locking around completion

nvme_poll_queues is already protected by q->lock, and
AIO callbacks are invoked outside the AioContext lock.
So remove the acquire/release pair in nvme_handle_event.

Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: c7f79d678f8cb3bd54cdbe283f8fad9ecc31b643
      
https://github.com/qemu/qemu/commit/c7f79d678f8cb3bd54cdbe283f8fad9ecc31b643
  Author: Peter Maydell <address@hidden>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M block/nvme.c
    M iothread.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/famz/tags/block-pull-request' into 
staging

Block patches

One fix from Paolo on nvme:// driver.
One fix from Marc-Andre for iothread.

# gpg: Signature made Fri 12 Oct 2018 02:49:42 BST
# gpg:                using RSA key CA35624C6A9171C6
# gpg: Good signature from "Fam Zheng <address@hidden>"
# Primary key fingerprint: 5003 7CB7 9706 0F76 F021  AD56 CA35 624C 6A91 71C6

* remotes/famz/tags/block-pull-request:
  nvme: correct locking around completion
  iothread: fix crash with invalid properties

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/05b656dcaa62...c7f79d678f8c
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.