[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 5/8] file-posix: Support auto-read-only option
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PATCH v2 5/8] file-posix: Support auto-read-only option |
Date: |
Fri, 12 Oct 2018 13:55:29 +0200 |
If read-only=off, but auto-read-only=on is given, open the file
read-write if we have the permissions, but instead of erroring out for
read-only files, just degrade to read-only.
Signed-off-by: Kevin Wolf <address@hidden>
---
block/file-posix.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/block/file-posix.c b/block/file-posix.c
index 2da3a76355..eead3f2df3 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -527,6 +527,19 @@ static int raw_open_common(BlockDriverState *bs, QDict
*options,
s->fd = -1;
fd = qemu_open(filename, s->open_flags, 0644);
+
+ if (fd < 0 && (errno == EACCES || errno == EROFS)) {
+ /* Try to degrade to read-only, but if it doesn't work, still use the
+ * normal error message. */
+ ret = bdrv_apply_auto_read_only(bs, NULL, NULL);
+ if (ret == 0) {
+ bdrv_flags &= ~BDRV_O_RDWR;
+ raw_parse_flags(bdrv_flags, &s->open_flags);
+ assert(!(s->open_flags & O_CREAT));
+ fd = qemu_open(filename, s->open_flags);
+ }
+ }
+
if (fd < 0) {
ret = -errno;
error_setg_errno(errp, errno, "Could not open '%s'", filename);
--
2.19.1
- Re: [Qemu-block] [PATCH v2 2/8] block: Add auto-read-only option, (continued)
- [Qemu-block] [PATCH v2 4/8] nbd: Support auto-read-only option, Kevin Wolf, 2018/10/12
- [Qemu-block] [PATCH v2 7/8] gluster: Support auto-read-only option, Kevin Wolf, 2018/10/12
- [Qemu-block] [PATCH v2 5/8] file-posix: Support auto-read-only option,
Kevin Wolf <=
- [Qemu-block] [PATCH v2 6/8] curl: Support auto-read-only option, Kevin Wolf, 2018/10/12
- [Qemu-block] [PATCH v2 8/8] iscsi: Support auto-read-only option, Kevin Wolf, 2018/10/12