[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 7/8] gluster: Support auto-read-only option
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PATCH v2 7/8] gluster: Support auto-read-only option |
Date: |
Fri, 12 Oct 2018 13:55:31 +0200 |
If read-only=off, but auto-read-only=on is given, open the file
read-write if we have the permissions, but instead of erroring out for
read-only files, just degrade to read-only.
Signed-off-by: Kevin Wolf <address@hidden>
---
block/gluster.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/block/gluster.c b/block/gluster.c
index 4fd55a9cc5..68d20c8830 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -849,6 +849,15 @@ static int qemu_gluster_open(BlockDriverState *bs, QDict
*options,
qemu_gluster_parse_flags(bdrv_flags, &open_flags);
s->fd = glfs_open(s->glfs, gconf->path, open_flags);
+ if (!s->fd && errno == EACCES) {
+ /* Try to degrade to read-only, but if it doesn't work, still use the
+ * normal error message. */
+ ret = bdrv_apply_auto_read_only(bs, NULL, NULL);
+ if (ret == 0) {
+ open_flags = (open_flags & ~O_RDWR) | O_RDONLY;
+ s->fd = glfs_open(s->glfs, gconf->path, open_flags);
+ }
+ }
if (!s->fd) {
ret = -errno;
}
--
2.19.1
[Qemu-block] [PATCH v2 4/8] nbd: Support auto-read-only option, Kevin Wolf, 2018/10/12
[Qemu-block] [PATCH v2 7/8] gluster: Support auto-read-only option,
Kevin Wolf <=
[Qemu-block] [PATCH v2 5/8] file-posix: Support auto-read-only option, Kevin Wolf, 2018/10/12
[Qemu-block] [PATCH v2 6/8] curl: Support auto-read-only option, Kevin Wolf, 2018/10/12
[Qemu-block] [PATCH v2 8/8] iscsi: Support auto-read-only option, Kevin Wolf, 2018/10/12