Re: [PATCH 08/12] hw/char/pl011: Extract pl011_write_tx() from pl011

qemu-arm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/12] hw/char/pl011: Extract pl011_write_tx() from pl011_wri

From:	Alex Bennée
Subject:	Re: [PATCH 08/12] hw/char/pl011: Extract pl011_write_tx() from pl011_write()
Date:	Tue, 23 May 2023 14:36:25 +0100
User-agent:	mu4e 1.11.6; emacs 29.0.91

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> When implementing FIFO, this code will become more complex.
> Start by factoring it out to a new pl011_write_tx() function.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 01/12] util/fifo8: Fix typo in fifo8_push_all() description, (continued)
- [PATCH 01/12] util/fifo8: Fix typo in fifo8_push_all() description, Philippe Mathieu-Daudé, 2023/05/22
  - Re: [PATCH 01/12] util/fifo8: Fix typo in fifo8_push_all() description, Francisco Iglesias, 2023/05/22
  - Re: [PATCH 01/12] util/fifo8: Fix typo in fifo8_push_all() description, Alex Bennée, 2023/05/23
- [PATCH 05/12] hw/char/pl011: Remove duplicated PL011_INT_[RT]X definitions, Philippe Mathieu-Daudé, 2023/05/22
  - Re: [PATCH 05/12] hw/char/pl011: Remove duplicated PL011_INT_[RT]X definitions, Alex Bennée, 2023/05/23
- [PATCH 07/12] hw/char/pl011: Split RX/TX path of pl011_reset_fifo(), Philippe Mathieu-Daudé, 2023/05/22
  - Re: [PATCH 07/12] hw/char/pl011: Split RX/TX path of pl011_reset_fifo(), Alex Bennée, 2023/05/23
- [PATCH 06/12] hw/char/pl011: Replace magic values by register field definitions, Philippe Mathieu-Daudé, 2023/05/22
  - Re: [PATCH 06/12] hw/char/pl011: Replace magic values by register field definitions, Alex Bennée, 2023/05/23
- [PATCH 08/12] hw/char/pl011: Extract pl011_write_tx() from pl011_write(), Philippe Mathieu-Daudé, 2023/05/22
  - Re: [PATCH 08/12] hw/char/pl011: Extract pl011_write_tx() from pl011_write(), Alex Bennée <=
- [PATCH 09/12] hw/char/pl011: Check if transmitter is enabled, Philippe Mathieu-Daudé, 2023/05/22
  - Re: [PATCH 09/12] hw/char/pl011: Check if transmitter is enabled, Alex Bennée, 2023/05/23
  - Re: [PATCH 09/12] hw/char/pl011: Check if transmitter is enabled, Peter Maydell, 2023/05/25
    - Re: [PATCH 09/12] hw/char/pl011: Check if transmitter is enabled, Alex Bennée, 2023/05/25
    - Re: [PATCH 09/12] hw/char/pl011: Check if transmitter is enabled, Peter Maydell, 2023/05/25
    - Re: [PATCH 09/12] hw/char/pl011: Check if transmitter is enabled, Philippe Mathieu-Daudé, 2023/05/25
- [PATCH 10/12] hw/char/pl011: Check if receiver is enabled, Philippe Mathieu-Daudé, 2023/05/22
  - Re: [PATCH 10/12] hw/char/pl011: Check if receiver is enabled, Alex Bennée, 2023/05/23
- [PATCH 11/12] hw/char/pl011: Rename RX FIFO methods, Philippe Mathieu-Daudé, 2023/05/22
  - Re: [PATCH 11/12] hw/char/pl011: Rename RX FIFO methods, Alex Bennée, 2023/05/23

Prev by Date: Re: [PATCH 07/12] hw/char/pl011: Split RX/TX path of pl011_reset_fifo()
Next by Date: Re: [PATCH 09/12] hw/char/pl011: Check if transmitter is enabled
Previous by thread: [PATCH 08/12] hw/char/pl011: Extract pl011_write_tx() from pl011_write()
Next by thread: [PATCH 09/12] hw/char/pl011: Check if transmitter is enabled
Index(es):
- Date
- Thread