[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 08/12] hw/char/pl011: Extract pl011_write_tx() from pl011_write()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 08/12] hw/char/pl011: Extract pl011_write_tx() from pl011_write() |
Date: |
Mon, 22 May 2023 17:31:40 +0200 |
When implementing FIFO, this code will become more complex.
Start by factoring it out to a new pl011_write_tx() function.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/char/pl011.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/hw/char/pl011.c b/hw/char/pl011.c
index f0b305e5d7..c55ef41fbf 100644
--- a/hw/char/pl011.c
+++ b/hw/char/pl011.c
@@ -149,6 +149,17 @@ static inline void pl011_reset_tx_fifo(PL011State *s)
s->flags |= PL011_FLAG_TXFE;
}
+static void pl011_write_tx(PL011State *s, const uint8_t *buf, int length)
+{
+ /* ??? Check if transmitter is enabled. */
+
+ /* XXX this blocks entire thread. Rewrite to use
+ * qemu_chr_fe_write and background I/O callbacks */
+ qemu_chr_fe_write_all(&s->chr, buf, 1);
+ s->int_level |= INT_TX;
+ pl011_update(s);
+}
+
static uint64_t pl011_read(void *opaque, hwaddr offset,
unsigned size)
{
@@ -262,19 +273,12 @@ static void pl011_write(void *opaque, hwaddr offset,
uint64_t value, unsigned size)
{
PL011State *s = (PL011State *)opaque;
- unsigned char ch;
trace_pl011_write(offset, value, pl011_regname(offset));
switch (offset >> 2) {
case 0: /* UARTDR */
- /* ??? Check if transmitter is enabled. */
- ch = value;
- /* XXX this blocks entire thread. Rewrite to use
- * qemu_chr_fe_write and background I/O callbacks */
- qemu_chr_fe_write_all(&s->chr, &ch, 1);
- s->int_level |= INT_TX;
- pl011_update(s);
+ pl011_write_tx(s, (uint8_t *) &value, 1);
break;
case 1: /* UARTRSR/UARTECR */
s->rsr = 0;
--
2.38.1
- Re: [PATCH 04/12] hw/char/pl011: Display register name in trace events, (continued)
- [PATCH 01/12] util/fifo8: Fix typo in fifo8_push_all() description, Philippe Mathieu-Daudé, 2023/05/22
- [PATCH 05/12] hw/char/pl011: Remove duplicated PL011_INT_[RT]X definitions, Philippe Mathieu-Daudé, 2023/05/22
- [PATCH 07/12] hw/char/pl011: Split RX/TX path of pl011_reset_fifo(), Philippe Mathieu-Daudé, 2023/05/22
- [PATCH 06/12] hw/char/pl011: Replace magic values by register field definitions, Philippe Mathieu-Daudé, 2023/05/22
- [PATCH 08/12] hw/char/pl011: Extract pl011_write_tx() from pl011_write(),
Philippe Mathieu-Daudé <=
- [PATCH 09/12] hw/char/pl011: Check if transmitter is enabled, Philippe Mathieu-Daudé, 2023/05/22
[PATCH 10/12] hw/char/pl011: Check if receiver is enabled, Philippe Mathieu-Daudé, 2023/05/22
[PATCH 11/12] hw/char/pl011: Rename RX FIFO methods, Philippe Mathieu-Daudé, 2023/05/22