octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #54952] optimset (old, new) uses empty fields


From: Olaf Till
Subject: [Octave-bug-tracker] [bug #54952] optimset (old, new) uses empty fields from 'new'
Date: Sat, 8 Dec 2018 05:46:12 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0

Update of bug #54952 (project octave):

                  Status:          Patch Reviewed => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #9:

As for pushing, I don't seem to have the rights. So I just re-attached the
changeset (now 54952.cset) with only the commit message changed according to
your suggestion.

You convinced me that the changes of comment #6 can be kept, but in this case
I'd suggest that the comment in 
https://hg.savannah.gnu.org/hgweb/octave/file/a0b63c183d4b/scripts/optimization/__all_opts__.m#l44
should be changed from 'will call optimset' to 'may call optimset', so that
the precautions against this calling of optimset (possible in external code)
will not be removed from Octave later.

(file #45600)
    _______________________________________________________

Additional Item Attachment:

File name: 54952.cset                     Size:4 KB


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?54952>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]