[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #54952] optimset (old, new) uses empty fields
From: |
Olaf Till |
Subject: |
[Octave-bug-tracker] [bug #54952] optimset (old, new) uses empty fields from 'new' |
Date: |
Fri, 7 Dec 2018 09:55:37 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 |
Follow-up Comment #7, bug #54952 (project octave):
Sorry for coming in so late -- it's my current jobs fault...
I think this should rather be fixed within optimset. One reason is
Matlab-compatibility -- Matlabs optimset also preserves empty values if given
as arguments. Another reason is that we expected optimset to work this way all
the time, and external (optimization-)code may rely on it.
So I'd prefer the patch now attached. (55089.cset -- the commit message states
what the patch does.)
Kay, it could be argued that your patch could still be left in, but I'd
suggest to revert it. It's not necessary any more, and it used to be expected
(see comments in __all_opts__.m) that an optimization function calls optimset
to return its default options).
(file #45592)
_______________________________________________________
Additional Item Attachment:
File name: 55089.cset Size:4 KB
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?54952>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #54952] optimset (old, new) uses empty fields from 'new',
Olaf Till <=