Re: [lwip-devel] [PATCH] PPPoE: Fix build when PPPOE_TODO is defined

[Sylvain Rochet]

Hello Jacob,

On Tue, Dec 18, 2018 at 01:09:57PM +0100, Jacob Kroon wrote:
> On Tue, Dec 18, 2018 at 12:38 PM Sylvain Rochet <address@hidden> wrote:
> >
> > Thanks for your patch but I feel confused. I have no clue at all what
> > you are trying to achieve and the patch description is unfortunately
> > empty.
> 
> I was not sure wether or not I should append the compiler errors in
> the commit message, but the build fails due to passing incorrect
> pointer types otherwise.

That's what I use to do so we know what we are fixing, note that you can 
always append explanations in a patch that are not part of the commit 
message by using a --- separator or by using a cover letter.


> I can send a new version of the patch with the compiler errors in the
> message if that is acceptable ?

I had the same compiler complaint so I pushed the patch with all needed 
information.


> > What is the actual fix ? Why do you care about service name and
> > concentrator name support ? Is this enough for the feature to work ?
> >
> 
> This patch is just to fix the build. Yes I'm using the service name in
> my current project.

Let's make it a real feature then, I renamed PPPOE_TODO to 
PPPOE_SCNAME_SUPPORT and moved its definition to ppp_opts.h then I 
rebased your fix on top of that.

Sylvain

signature.asc
Description: Digital signature