Re: [lwip-devel] [PATCH] PPPoE: Fix build when PPPOE_TODO is defined

[Sylvain Rochet]

Hello Jacob,

On Mon, Dec 17, 2018 at 09:48:41PM +0100, Jacob Kroon wrote:
> ---
>  src/include/netif/ppp/pppoe.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/include/netif/ppp/pppoe.h b/src/include/netif/ppp/pppoe.h
> index 08ab7ab5..3c41445c 100644
> --- a/src/include/netif/ppp/pppoe.h
> +++ b/src/include/netif/ppp/pppoe.h
> @@ -150,8 +150,8 @@ struct pppoe_softc {
>    u8_t sc_state;               /* discovery phase or session connected */
>  
>  #ifdef PPPOE_TODO
> -  u8_t *sc_service_name;       /* if != NULL: requested name of service */
> -  u8_t *sc_concentrator_name;  /* if != NULL: requested concentrator id */
> +  char *sc_service_name;       /* if != NULL: requested name of service */
> +  char *sc_concentrator_name;  /* if != NULL: requested concentrator id */
>  #endif /* PPPOE_TODO */
>    u8_t sc_ac_cookie[PPPOE_MAX_AC_COOKIE_LEN]; /* content of AC cookie we 
> must echo back */
>    u8_t sc_ac_cookie_len;       /* length of cookie data */
> -- 
> 2.11.0

Thanks for your patch but I feel confused. I have no clue at all what 
you are trying to achieve and the patch description is unfortunately 
empty.

What is the actual fix ? Why do you care about service name and 
concentrator name support ? Is this enough for the feature to work ?

Sylvain

signature.asc
Description: Digital signature