19 янв. 2015 г., в 23:52, Peter Villeneuve <address@hidden> написал(а):
Great thanks.
Looking forward to seeing this ZRTP patch applied.
I noticed that in that repo there is no issue tracker. How do we signal issues to Belledone like the Note 2/3 black screen I've reported on the list before?
Cheers,
Peter
On Mon, Jan 19, 2015 at 9:22 AM, Ghislain MARY <address@hidden> wrote:
Yes but you want to add an uint8_t algoType argument(just
like bzrtpCrypto_getAvailableCryptoTypes function) to both
of them in order to use the same function to get/set the
available algos for block cipher/key exchange/SAS
rendering/Hash.
This means we also must add a way to store the user
configuration in
linphone. I was thinking the easiest way would be to
store it in the
config file and access it only manually for now. I can
implement this if
you're lost on the way linphone manage the config
file.
I haven't had a look to linphone config file
management, yet. Let's see how far
I get or if you find time first.
It's quite simple, but if you struggle tell me and I'll have
a look at it when you're done with bzrtp. We can use an
already existing config setting used to select SRTP
protection profile(see misc.c const MSCryptoSuite *
linphone_core_get_srtp_crypto_suites(LinphoneCore *lc);) for
the block cipher algo selection and do something for the
other algo types when needed.
Last, this must be covered by automatic tests.(Key
exchange between two
users using different set of cipher block algo)
I'm not sure what you mean: Would you prefer a test
similar to the existing
"test_algoAgreement" or would it be better to write a
test for the function
"selectCommonAlgo" directly?
I was thinking of extending the test_algoAgreement to
include block cipher selection and some test on linphone
call to check correct reading of the configuration from
file, but it can't harm to have a test for the
selectCommonAlgo too.