|
From: | Peter Villeneuve |
Subject: | Re: [Linphone-developers] bzrtp support for AES with 256-bit keys |
Date: | Sun, 18 Jan 2015 17:47:28 +0000 |
Hi Ben,
Yes. Just to be sure, did you mean implementing functions like this:
void bzrtp_setSupportedCipherTypes(bzrtpContext_t *zrtpContext, uint8_t
availableTypes[7], const uint8_t availableTypesCount);
uint8_t bzrtp_getSupportedCipherTypes(bzrtpContext_t *zrtpContext, uint8_t
availableTypes[7]);
Yes but you want to add an uint8_t algoType argument(just like bzrtpCrypto_getAvailableCryptoTypes function) to both of them in order to use the same function to get/set the available algos for block cipher/key exchange/SAS rendering/Hash.
It's quite simple, but if you struggle tell me and I'll have a look at it when you're done with bzrtp. We can use an already existing config setting used to select SRTP protection profile(see misc.c const MSCryptoSuite * linphone_core_get_srtp_crypto_suites(LinphoneCore *lc);) for the block cipher algo selection and do something for the other algo types when needed.This means we also must add a way to store the user configuration in
linphone. I was thinking the easiest way would be to store it in the
config file and access it only manually for now. I can implement this if
you're lost on the way linphone manage the config file.
I haven't had a look to linphone config file management, yet. Let's see how far
I get or if you find time first.
I was thinking of extending the test_algoAgreement to include block cipher selection and some test on linphone call to check correct reading of the configuration from file, but it can't harm to have a test for the selectCommonAlgo too.Last, this must be covered by automatic tests.(Key exchange between two
users using different set of cipher block algo)
I'm not sure what you mean: Would you prefer a test similar to the existing
"test_algoAgreement" or would it be better to write a test for the function
"selectCommonAlgo" directly?
Thanks for your contribution.
Have a good day
johan
_______________________________________________
Linphone-developers mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/linphone-developers
[Prev in Thread] | Current Thread | [Next in Thread] |