|
| From: | v . villenave |
| Subject: | Re: Charles Winston's chord-semantics GSOC work (issue 568650043 by address@hidden) |
| Date: | Mon, 08 Apr 2019 11:17:53 -0700 |
On 2019/04/06 22:06:22, Carl wrote:
However, this will require more refactoring. I don't believe we
should hold off
on this patch until we can get that part of it done better. This
patch has
lanquished long enough. IMO we should just push it as-is and get it
in the code
base.
Agreed. LGTM, and thanks for your work on that! Cheers, V. https://codereview.appspot.com/568650043/
| [Prev in Thread] | Current Thread | [Next in Thread] |