Re: [Libcdio-devel] CD_MSF_FORMAT vs LBA on NetBSD

[Edd Barrett]

On Sat, Dec 08, 2018 at 04:53:24PM +0100, Thomas Schmitt wrote:
> But i would really be surprised if it worked with the intermediate state
> where this was already in place:
> 
> >  11: 09:41:34  043459 audio  false  no    0        no
> > 170: 09:41:34  043459 leadout (97 MB raw, 97 MB formatted)
> 
> lead-out should start after track 11, not at the same address.
> What do you get from this run ?

Well spotted. I'd missed this.

To clarify, before the fix I posted in my previous email:
---8<---
CD-ROM Track List (7 - 5)
  #: MSF       LSN    Type   Green? Copy? Channels Premphasis?
  7: 00:02:00  000000 audio  false  no    0        no
  8: 03:07:72  013947 audio  false  no    0        no
  9: 05:46:12  025812 audio  false  no    0        no
 10: 07:24:74  033224 audio  false  no    0        no
 11: 09:41:34  043459 audio  false  no    0        no
170: 09:41:34  043459 leadout (97 MB raw, 97 MB formatted)
--->8---

And after:
---8<---
CD-ROM Track List (7 - 5)
  #: MSF       LSN    Type   Green? Copy? Channels Premphasis?
  7: 00:02:00  000000 audio  false  no    0        no
  8: 03:07:72  013947 audio  false  no    0        no
  9: 05:46:12  025812 audio  false  no    0        no
 10: 07:24:74  033224 audio  false  no    0        no
 11: 09:41:34  043459 audio  false  no    0        no
170: 12:48:10  057460 leadout (128 MB raw, 128 MB formatted)
--->8---

So the leadout is correct. But the following issue you pointed out does indeed
still persist:

> > CD-ROM Track List (7 - 5)
> 
> Shouldn't that be "(7 - 11)" ?
> I see in libcdio/src/cd-info.c :
> 
>     printf("CD-ROM Track List (%i - %i)\n" NORMAL,
>            i_first_track, i_tracks);
> 
> where "i_tracks" probably should be "i_first_track + i_tracks - 1".
> 
> Do you agree ?

I do! Again, well spotted!

https://github.com/vext01/libcdio/commit/561d7a8ed195e29a16cf87236c568531c1871031

---8<---
CD-ROM Track List (7 - 11)
  #: MSF       LSN    Type   Green? Copy? Channels Premphasis?
  7: 00:02:00  000000 audio  false  no    0        no
  8: 03:07:72  013947 audio  false  no    0        no
  9: 05:46:12  025812 audio  false  no    0        no
 10: 07:24:74  033224 audio  false  no    0        no
 11: 09:41:34  043459 audio  false  no    0        no
170: 12:48:10  057460 leadout (128 MB raw, 128 MB formatted)
--->8---

-- 
Best Regards
Edd Barrett

http://www.theunixzoo.co.uk