Re: [zile-devel] Update: static buffer overflows removed

[Nicolas Duboc]

On Wed, Mar 10, 2004 at 11:06:32AM +0100, Reuben Thomas wrote:
> >    Yes, the bug report I have submitted yesterday ;-)
> 
> [...] 
> Also, I'm worried that you can't compile CVS. What's the problem? I've
> been making lots of changes in the last couple of days, but I didn't think
> I'd committed anything that doesn't build.

  In fact, compiling after a simple "./configure" is OK.
But compiling after a "./configure --enable-all-modes" (as my debian
package does) produce the following error message :
----------------------------------------
% make                                                                   
address@hidden
[...]
Making all in term_ncurses
make[3]: Entering directory `/tmp/zile/src/term_ncurses'
gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../lib -I../../src    -g -O2 -c 
ncurses_key.c
gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../lib -I../../src    -g -O2 -c 
ncurses_minibuf.c
gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../lib -I../../src    -g -O2 -c 
ncurses_misc.c
gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../lib -I../../src    -g -O2 -c 
ncurses_redisplay.c
ncurses_redisplay.c: In function `draw_line_cpp':
ncurses_redisplay.c:430: warning: passing arg 1 of `in_region' makes
integer from pointer wit
hout a cast
ncurses_redisplay.c:430: warning: passing arg 2 of `in_region' makes
integer from pointer wit
hout a cast
ncurses_redisplay.c:430: warning: passing arg 3 of `in_region' makes
pointer from integer wit
hout a cast
ncurses_redisplay.c:430: error: too many arguments to function `in_region'
ncurses_redisplay.c:433: warning: passing arg 1 of `in_region' makes
integer from pointer wit
hout a cast
ncurses_redisplay.c:433: warning: passing arg 2 of `in_region' makes
integer from pointer wit
hout a cast
ncurses_redisplay.c:433: warning: passing arg 3 of `in_region' makes
pointer from integer wit
hout a cast
ncurses_redisplay.c:433: error: too many arguments to function `in_region'
[...]
-------------------------------------

Indeed it seems that the signature of the in_region function (line 344)
doesn't match the call to this function in the OUTCH macro (line 404).

---
Nicolas Duboc <address@hidden>