Re: What if the author field in a RCS file is a numeral as in 12345

[Arvind Raman]

Well my patch does work (Though I would think that it 
is an ugly fix) and it has been working for the past 
couple of years. 

I guess I have not fully comprehended the problem. I 
have installed CVSWeb and the CVSNt server and each 
time I see some file creating a problem, I see
several rlog processes spawned, none of them consuming
any CPU resources. When I delete these rlog processes
things start working again. 

I am ready to do that if thats all it entails, but off
late killing these processes has started deleting the 
RCS files on the database, which is definitely
becoming
a SERIOUS issue.

Since I changed thercssync.c file I kind of suspect
the
patch that I added

Arvind


--- "Aaron S. Hawley" <address@hidden> wrote:
> i can confirm this also:
> 
>     $ grep author RCS/food,v
>     date    2003.06.13.16.12.59;    author 8675309;
> state Exp;
>     $ rlog RCS/food,v
>     rlog: RCS/food,v:9: missing author
>     rlog aborted
> 
> my guess is the problem is in the lexer, but i'm
> having trouble
> decrypting anything from these sections of the code.
> /a
> 
> On Fri, 13 Jun 2003, Arvind Raman wrote:
> 
> > I came across this problem a few years agom when I
> > tried to fix the problem by myself, but off late I
> > have to suspect the fix that I did.
> >
> > I guess the rlog.c version 5.7 (windows) assumes
> that
> > the author field would be a string and would not
> be a
> > numeral.
> >
> > In our organization where the login IDs are
> numbers
> > the name of authors in the RCS file figures as a
> > numeral. I believe that the rlog executable in
> release
> >
> > 5.7 is unable to parse such files for as soon as I
> add
> >
> > an alphanumeric character like "a" in front of the
> > numeral the rlog parses the file without any
> error.
> >
> > Does the restriction of the author name not being
> a
> > numeral there with a reason. If thats the case I
> > definitely need to find a work around it. I made
> the
> > following change to the rcssync.c file in the
> function
> > getkeyval(keyword, token, optional) the diff of
> which
> > is listed below
> >
> > 495,499d494
> > <       if (strcmp(keyword,"author") == 0)
> > <       {
> > <               nexttok = token;
> > <       }
> >
> > Could anyone let me know if this is a valid fix,
> if
> > not could someone point out to resources that
> could
> > help me out.
> >
> > Thanks and regards
> > Arvind
> 
> -- 
> "I didn't work here in 1991. You may want to talk to
> the Pentagon about
>  anything that took place then."
>  - White Spokesperson Ari Fleischer responding to
> questions about the
>    intentional bombing of Iraqi water treatment
> facilities in Gulf War I


__________________________________
Do you Yahoo!?
Yahoo! Calendar - Free online calendar with sync to Outlook(TM).
http://calendar.yahoo.com