Re: [H-source-users] [PATCH] update README for PHP7,8

[Yuchen Pei]

Hi bill-auger,

Regarding
<https://git.savannah.nongnu.org/cgit/h-source.git/commit/?h=wip-documentation&id=2820e9b78b26df12bbff01336c73e624601839cd>:

> --- a/README.org
> +++ /dev/null

I notice that the README.org file is removed in favour of the
README.txt.  I'm ok with that, but what markup is README.txt using?

> +The DB server must have strict mode set to 'off'. The default must be
> changed in MariaDB 10.2+ or MySQL 5.7+.

s/strict mode/STRICT_TRANS_MODE/

> +* FIXME: i did not need to do that

Does this mean you had STRICT_TRANS_MODE on and did not have problems
described in <https://savannah.nongnu.org/bugs/index.php?62574>?

> -Extract the tarball inside a folder of your filesystem.
> +Extract the tarball or clone the VCS to your filesystem.

Nit: I think it's more likely people clone from git than extract the
tarball so I suggest swap the order of these two.

Will continue the review another day.

Best,
Yuchen

-- 
PGP Key: 47F9 D050 1E11 8879 9040  4941 2126 7E93 EF86 DFD0
          <https://ypei.org/assets/ypei-pubkey.txt>