freetype
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft] FT_New_Face and PCF fonts


From: Akira TAGOH
Subject: Re: [ft] FT_New_Face and PCF fonts
Date: Wed, 25 Sep 2013 18:14:39 +0900

Thanks for the fix. I'm looking forward to see that in a release :)

On Wed, Sep 25, 2013 at 11:04 AM, suzuki toshiya
<address@hidden> wrote:
> Hi,
>
> Just I've committed, now PCF and BDF drivers return invalid
> argument error when non-zero face index is given.
>
> BTW, the argument checks are done AFTER the opening of the
> font file by each driver. Although I was going to change the
> drivers to refuse non-zero face index immediately without
> any allocation and any reading, Type1 and Type42 drivers are
> designed to check invalid face index AFTER the opening of
> the font file, so I followed it.
>
> If anybody thinks the immediate refusal is better, please post!
>
> Regards,
> mpsuzuki
>
> On 09/24/2013 01:46 PM, Werner LEMBERG wrote:
>>
>>> I could not find any record changing to allow such, from git commit
>>> log, so I guess it is unexpected/overlooked behaviour.  I want to
>>> change it to return an error (invalid argument or something else?).
>>> Werner, more consideration is expected?
>>
>> Certainly a bug.  Of course it should return `invalid argument'.
>>
>> Thanks for the report and the forthcoming fix :-)
>>
>>
>>      Werner
>>
>



-- 
Akira TAGOH



reply via email to

[Prev in Thread] Current Thread [Next in Thread]