Re: 3 patches for freetype2 / freetype2-demo, and etc

[Hin-Tak Leung]

On Sunday, 9 July 2023 at 05:17:55 BST, Werner LEMBERG <wl@gnu.org> wrote:

> >> Hmm, what exactly do you suggest?  `FT_LibraryRec` is an internal
> >> structure not exposed to the public, so it could be changed easily
> >> without any backward compatibility issues.
> >
> > Exactly as what I wrote - if a next major version of freetype (3)
> > happens, and one is allowed to break backward compatibility.

> Perhaps a misunderstanding: I want to know how *the code* should be
> changed.  Can you provide a pseudo-patch or something like that?

I just means something like this - it being before "modules[FT_MAX_MODULES]" (a structure changeable in size per build/release) in particular.

diff --git a/include/freetype/internal/ftobjs.h b/include/freetype/internal/ftobjs.h
index 9f33d9c30..c768ce892 100644
--- a/include/freetype/internal/ftobjs.h
+++ b/include/freetype/internal/ftobjs.h
@@ -904,6 +904,7 @@ FT_BEGIN_HEADER
FT_Int version_minor;
FT_Int version_patch;

+ FT_DebugHook_Func debug_hooks[4];
FT_UInt num_modules;
FT_Module modules[FT_MAX_MODULES]; /* module objects */

@@ -911,7 +912,6 @@ FT_BEGIN_HEADER
FT_Renderer cur_renderer; /* current outline renderer */
FT_Module auto_hinter;

- FT_DebugHook_Func debug_hooks[4];

#ifdef FT_CONFIG_OPTION_SUBPIXEL_RENDERING
FT_LcdFiveTapFilter lcd_weights; /* filter weights, if any */