Re: Proposal draft

[Sebastian Koslowski]

Hi Ruben,

thanks for the proposal and your interest in the project.

Some quick feedback:

* GRC files no longer use XML. Checkout the examples in the main repo, e.g. https://github.com/gnuradio/gnuradio/blob/main/gr-channels/examples/demo_ofdm.grc

* There is a feature to auto-generate "not-embedded" flow graphs, which you could study. Maybe mention how it relates to the proposal, https://github.com/gnuradio/gnuradio/blob/0ecc1127df9c665e669e6b6711d15741b7e6fec9/grc/core/FlowGraph.py#L435

* Embedded flowgraphs could be instantiated multiple times, possibly even within another embedded flowgraph. I suggest to add a discussion on how this would work and look like. (list of graphs, create,copy,unlink blocks that represent subflowgraphs)

-Sebastian

(von unterwegs gesendet)

On Fri, Mar 15, 2024, 07:08 Ruben Arciba <arcibaruben@gmail.com> wrote:

Sorry, forgot to attach my proposal to the previous email.

On Fri, Mar 15, 2024 at 12:06 AM Ruben Arciba <arcibaruben@gmail.com> wrote:

Hello,

My name is Ruben, I have created a draft of my proposal for the project "GRC: Build-in Sub flowgraphs". I would appreciate your input on how I can improve my proposal. Hope to hear from you soon.

Thank you,

Ruben Arciba.