[certi-dev] TransportType vs. TransportationHandle

[Gotthard, Petr]

Hi Pierre,

could you please let me know your opinion concerning

https://savannah.nongnu.org/bugs/?24516

 

Here goes a (not so) short summary.

 

The RTItypes.hh defines two strange types: TransportType and OrderType. For example, let's have a look at TransportType:

 

(1)

The TransportationHandle seems to be of the same type as TransportType.

typedef TransportationHandle TransportType ;

 

but internally in CERTI the same enum is represented by different values:

TransportType BestEffort = 2, but TransportationHandle BestEffort = 0

 

(2)

There is no way how to get the TransportType, because getTransportationHandle() returns TransportationHandle.

    TransportationHandle getTransportationHandle(const char *);

Curiously, the TransportationHandle is also used as a parameter of changeAttributeTransportationType().

    void changeAttributeTransportationType(ObjectHandle, const AttributeHandleSet &, TransportationHandle);

 

This suggests that TransportationHandle and TransportType are mean to be identical. This contradicts to CERTI imeplementation mentioned in (1).

 

(3)

But that's not enough. :-( There is exception in certi.hh (marked as "deprecated") named "InvalidTransportType", although the HLA standard defines "InvalidTransportationHandle".

The deprecated exception is still in use, although I think the InvalidTransportationHandle should be used instead.

 

 

I believe that:

 -- TransportationHandle and TransportType should have the same enum values (but both types must be kept, because both are defined in HLA 1.3)

 -- to reduce the mess, the deprecated InvalidTransportType should be removed (because it's not defined neither in HLA 1.3, nor in IEEE 1516.1) and only InvalidTransportationHandle should be used.

 

And the same for OrderType. Do you have the same view?

 

 

Thanks and regards,

Petr