[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnulib-tool.py: Fix --extract-recursive-link-directive.
|
From: |
Collin Funk |
|
Subject: |
Re: [PATCH] gnulib-tool.py: Fix --extract-recursive-link-directive. |
|
Date: |
Thu, 21 Mar 2024 11:18:13 -0700 |
|
User-agent: |
Mozilla Thunderbird |
Hi Bruno,
On 3/21/24 9:00 AM, Bruno Haible wrote:
> Thanks. So, we are still finding logic bugs... Which proves that the
> test suite is necessary. I don't think we would have found this typo
> by mere code review (within a finite time).
Yes, agreed. The info-tests/* are very quick so it is easy to check
changes like this. If I remember correctly, when implementing
--extract-recursive-link-directive, I couldn't think of any good test
cases.
> Thanks. Applied, except for the change to link_sections.
Yes that makes more sense now that I look at gnulib-tool.sh.
Collin