bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] gnulib-tool.py: Fix --extract-recursive-link-directive.


From: Collin Funk
Subject: [PATCH] gnulib-tool.py: Fix --extract-recursive-link-directive.
Date: Wed, 20 Mar 2024 19:29:02 -0700
User-agent: Mozilla Thunderbird

This patch fixes the failure of
'test-extract-recursive-link-directive-3.sh' in the gnulib-tool test
suite:

cmp: EOF on tmp529181-out which is empty
--- ./test-extract-recursive-link-directive-3.output    2024-03-20 
19:16:08.842291576 -0700
+++ tmp529181-out       2024-03-20 19:17:56.295403277 -0700
@@ -1,2 +0,0 @@
-$(MBRTOWC_LIB)
-$(SETLOCALE_LIB)
FAIL: gnulib-tool's output has unexpected differences.
FAIL: test-extract-recursive-link-directive-3.sh

Due to this typo

             for module in inmodules_this_round:
-                if self.getLink() != '':
+                if module.getLink() != '':

the only 'Link:' section checked is from the original module.
Therefore, for this test, the 'mbsinit' and 'setlocale' modules are
missed.

Since we want to remove duplicate link directives, I have also changed
the lists to sets.

Collin

Attachment: 0001-gnulib-tool.py-Fix-extract-recursive-link-directive.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]