bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode'

[Jim Porter]

On 2/7/2024 9:37 AM, Juri Linkov wrote:
> > The main issue was that outline.el uses 'line-beginning-position' and
> > friends, which respects field boundaries, but I think we want to avoid that
> > for 'outline-minor-mode'. Maybe we could use 'pos-bol' and friends instead,
> > but my understanding is that 'line-beginning-position' respects display
> > directionality (which we probably want), but 'pos-bol' doesn't.
>
> I'm not aware of any cases that would require restricting
> outlines to field boundaries.

Thanks. After reading the source (generally a good idea), I now see that 
'line-beginning-position' doesn't respect display directionality, so 
there's no reason to use it over 'pos-bol' and friends. I've therefore 
updated the patch to use those, which makes things a bit simpler.

(In any case, I think for RTL, we'd want to use the logical ordering of 
the text anyway, but possibly add the outline buttons on the right side 
of the window instead. That's out of scope for this bug though.)

> There is also one occurrence of 'line-end-position' in outline.el.
> Should it have 'inhibit-field-text-motion' as well?

Thanks for the catch. Updated this as well.

(I also split out the Eshell demonstration patch so that I can drop the 
commit more easily before merging. It's still attached here though in 
case you or anyone else want to try it out.)

0001-Make-outline.el-ignore-field-properties-in-text.patch
Description: Text document

0002-DO-NOT-MERGE-Test-commit-for-previous-patch.patch
Description: Text document