[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode
From: |
Juri Linkov |
Subject: |
bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' |
Date: |
Wed, 07 Feb 2024 19:37:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) |
> I'd like to add support for 'outline-minor-mode' in Eshell. However,
> Eshell's use of field properties confuses outline.el. Attached is a WIP
> patch + demo code for Eshell that should resolve this.
>
> The main issue was that outline.el uses 'line-beginning-position' and
> friends, which respects field boundaries, but I think we want to avoid that
> for 'outline-minor-mode'. Maybe we could use 'pos-bol' and friends instead,
> but my understanding is that 'line-beginning-position' respects display
> directionality (which we probably want), but 'pos-bol' doesn't.
I'm not aware of any cases that would require restricting
outlines to field boundaries.
> You can try things out here by starting Eshell and activating
> 'outline-minor-mode'. You can also see the problems by applying only the
> Eshell part of the patch.
Thanks. I tried and confirm that your outline.el patch fixes the issue.
> Any thoughts? Is this the right way to go about this? (Note: I think the
> Eshell side of things will take more work, which I'll address in a later
> bug. However, this should be enough to show off the problems on the
> outline.el side.)
There is also one occurrence of 'line-end-position' in outline.el.
Should it have 'inhibit-field-text-motion' as well?
- bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode', Jim Porter, 2024/02/01
- bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode',
Juri Linkov <=
- bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode', Juri Linkov, 2024/02/11
- bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode', Jim Porter, 2024/02/11
- bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode', Juri Linkov, 2024/02/12
- bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode', Jim Porter, 2024/02/12