[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#66575: [PATCH] Gud lldb support
From: |
Mattias Engdegård |
Subject: |
bug#66575: [PATCH] Gud lldb support |
Date: |
Tue, 17 Oct 2023 11:00:35 +0200 |
16 okt. 2023 kl. 16.09 skrev Gerd Möllmann <gerd.moellmann@gmail.com>:
>> So what is the currently blessed way to communicate with LLDB?
>
> Don't really know, I'm afraid.
Maybe it's worth a try anyway, since lldb-mi still seems maintained as a
separate tool.
(But don't let it hold up your contribution -- it's useful on its own.)
>> If thñe file name can have an absolute directory part, then it may run
>> into trouble on Windows (C:\Some\Dir\File.c).
>
> I guess I'll leave that as an exercise for someone having Windows :-).
I don't, but we could try to be nice anyway. What about replacing
(group (1+ (not ":")))
with something like
(group (opt (opt "\\\\?\\") ; Windows fun
(in "a-zA-Z") ":") ; floppy letter
(1+ (not ":")))
and ignore NTFS Alternate Data Streams, as we ignore the possibility of colons
in file names on other systems?
Onto your most recent patch -- looks fine in general, only a few notes:
> * Editing Changes in Emacs 30.1
>
> ++++
> +** New command 'lldb'.
The text can be rearranged later on but this entry probably belongs under
'Changes in Specialized Modes and Packages'.
> +Run the LLDB debugger, analogous to the 'gud-gdb' command. Note that
> +might want to add these settings to your .lldbinit file, to reduce the
Missing 'you' in the second sentence?
> +output in the LLDB output when stepping through source files.
> +
> +settings set stop-line-count-before 0
> +settings set stop-line-count-after 0
Indent these lines by 4 spaces (NEWS has its own formatting rules).
But shouldn't your new code issue these commands to lldb automatically? The
user might not always run lldb under Emacs.
> + ;; First line is the print command itself.
> + (unless (string-match (regexp-quote (gud-tooltip-print-command ""))
Isn't this just (string-search ...) ? Or did you want a more precise match, in
which case it probably should be anchored in some way and not just a substring
search?
> +# This is for M-x lldb: don't show source lines when stopping.
> +settings set stop-line-count-before 0
> +settings set stop-line-count-after 0
As mentioned above, I'd hope we could do without this.
- bug#66575: [PATCH] Gud lldb support, Gerd Möllmann, 2023/10/16
- bug#66575: [PATCH] Gud lldb support, Mattias Engdegård, 2023/10/16
- bug#66575: [PATCH] Gud lldb support, Gerd Möllmann, 2023/10/16
- bug#66575: [PATCH] Gud lldb support,
Mattias Engdegård <=
- bug#66575: [PATCH] Gud lldb support, Gerd Möllmann, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Mattias Engdegård, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Gerd Möllmann, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Mattias Engdegård, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Gerd Möllmann, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Gerd Möllmann, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Gerd Möllmann, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Mattias Engdegård, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Gerd Möllmann, 2023/10/17