[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#66575: [PATCH] Gud lldb support
From: |
Gerd Möllmann |
Subject: |
bug#66575: [PATCH] Gud lldb support |
Date: |
Mon, 16 Oct 2023 16:09:38 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Mattias Engdegård <mattias.engdegard@gmail.com> writes:
>> No MI support, because lldb-mi is no longer part of LLVM.
>
> So what is the currently blessed way to communicate with LLDB?
Don't really know, I'm afraid.
> I only have comments about trivialities here; someone else should deal
> with the serious stuff.
>
>> +(eval-when-compile (require 'rx))
>
> There is usually no need to import rx explicitly. The necessary macros
> and functions are autoloaded.
>
>> +;; because gud-symbol uses their values if they are present. Tehir
>> +;; names are deducded from the minor-mode name.
>
> 'Their', 'deduced'.
>
>> + ;; frame #0: ...) at emacs.c:1310:9 [opt]
>> + (string-match (rx (and line-start (0+ blank) "frame"
>> + (0+ not-newline) " at "
>> + (group (1+ (not (any ":"))))
>> + ":"
>
>
> (You can write (not ":") instead of (not (any ":")) if you like.)
Both Fixed in the attached patch. I also found another spelling error
in an option passed to 'breakpoint set -joint...'.
> If thñe file name can have an absolute directory part, then it may run
> into trouble on Windows (C:\Some\Dir\File.c).
I guess I'll leave that as an exercise for someone having Windows :-).
>
> Sad that we throw away the column number here, but perhaps that's just
> a limitation of gud.el.
Indeed.
>
> Anyway, a big step up from not having any support at all. Thank you!
👍
>
> Would you include a NEWS entry as well?
When I get this into master, yes of course. I'm not yet convinced of
that :-).
0001-Gud-lldb-support.patch
Description: patch version 2
- bug#66575: [PATCH] Gud lldb support, Gerd Möllmann, 2023/10/16
- bug#66575: [PATCH] Gud lldb support, Mattias Engdegård, 2023/10/16
- bug#66575: [PATCH] Gud lldb support,
Gerd Möllmann <=
- bug#66575: [PATCH] Gud lldb support, Mattias Engdegård, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Gerd Möllmann, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Mattias Engdegård, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Gerd Möllmann, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Mattias Engdegård, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Gerd Möllmann, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Gerd Möllmann, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Gerd Möllmann, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Mattias Engdegård, 2023/10/17
- bug#66575: [PATCH] Gud lldb support, Gerd Möllmann, 2023/10/17