[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnec
From: |
Manphiz |
Subject: |
bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting |
Date: |
Sat, 23 Sep 2023 15:34:21 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Philip Kaludercic <philipk@posteo.net> writes:
> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Manphiz <manphiz@gmail.com> writes:
>>
>>>> I don't necessarily object, but is it a regression?
>>>
>>> The reconnecting and rejoining channels feature is broken in certain
>>> situation, and this patch fixes that. Some other users claimed this
>>> works for them, so I would say this may be considered a regression.
>>>
>>>> Is the change safe?
>>>
>>> According to the logic of the code, this patch enables doing work that
>>> (I believe) should have been done and not changing anything else, so I
>>> would say it is safe.
>>>
>>>> If the answer to either of those questions is "no", I think master is
>>>> the safer choice.
>>>
>>> I would say the answers are both yes, but of course that's just my
>>> opinion and the decision is up to you :)
>>
>> Thanks. If Philip agrees, I see no reason why this can't be installed
>> on emacs-29.
>
> I am fine with it as well, so I'll cherry-pick the branch from master
> onto emacs-29.
Great! Thanks everyone!
- bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting, (continued)
- bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting, Philip Kaludercic, 2023/09/15
- bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting, Manphiz, 2023/09/15
- bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting, Manphiz, 2023/09/21
- bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting, Philip Kaludercic, 2023/09/21
- bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting, Manphiz, 2023/09/21
- bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting, Philip Kaludercic, 2023/09/22
- bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting, Stefan Kangas, 2023/09/22
- bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting, Manphiz, 2023/09/22
- bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting, Stefan Kangas, 2023/09/23
- bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting, Philip Kaludercic, 2023/09/23
- bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting,
Manphiz <=
bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting, Manphiz, 2023/09/14