[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65854: Multi-file replacement diff
From: |
Eli Zaretskii |
Subject: |
bug#65854: Multi-file replacement diff |
Date: |
Fri, 22 Sep 2023 10:25:24 +0300 |
> From: Juri Linkov <juri@linkov.net>
> Cc: me@eshelyaron.com, 65854@debbugs.gnu.org
> Date: Fri, 22 Sep 2023 09:55:40 +0300
>
> +(defcustom multi-file-diff-unsaved 'save-buffers
> + "What to do with unsaved edits when showing multi-file replacements as
> diffs.
> +If the value is `save-buffers', save unsaved buffers before creating diff.
> +If the value is `use-file', use text from the file even when the visiting
> +file buffer is modified.
> +If the value is `use-modified-buffer', use text from the file-visiting
> +modified buffer to be able to use unsaved changes. However, when the file
> +is not visited in a buffer, or the buffer is not modified, still read
> +contents from the file."
Please use consistent wording to describe the same entities. If you
use "file-visiting buffer", use it everywhere, when you sometimes use
that and sometimes "visiting file buffer", you are already half way to
confusing the reader.
Also, this part:
> + However, when the file
> +is not visited in a buffer, or the buffer is not modified, still read
> +contents from the file."
Seems to describe an implementation detail, and I don't think it
should be there. E.g., what if the file visited by the buffer no
longer exists?
Thanks.
- bug#65854: Multi-file replacement diff, (continued)
- bug#65854: Multi-file replacement diff, Juri Linkov, 2023/09/11
- bug#65854: Multi-file replacement diff, Eli Zaretskii, 2023/09/11
- bug#65854: Multi-file replacement diff, Juri Linkov, 2023/09/12
- bug#65854: Multi-file replacement diff, Juri Linkov, 2023/09/15
- bug#65854: Multi-file replacement diff, Eshel Yaron, 2023/09/15
- bug#65854: Multi-file replacement diff, Eli Zaretskii, 2023/09/15
- bug#65854: Multi-file replacement diff, Juri Linkov, 2023/09/22
- bug#65854: Multi-file replacement diff,
Eli Zaretskii <=
- bug#65854: Multi-file replacement diff, Juri Linkov, 2023/09/22
- bug#65854: Multi-file replacement diff, Eli Zaretskii, 2023/09/22
- bug#65854: Multi-file replacement diff, Juri Linkov, 2023/09/23
- bug#65854: Multi-file replacement diff, Eli Zaretskii, 2023/09/23
- bug#65854: Multi-file replacement diff, Juri Linkov, 2023/09/24
- bug#65854: Multi-file replacement diff, Eli Zaretskii, 2023/09/24
- bug#65854: Multi-file replacement diff, Juri Linkov, 2023/09/25
bug#65854: Multi-file replacement diff, Dmitry Gutov, 2023/09/23