bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#65673: [PATCH] Add lua-ts-mode


From: Augusto Stoffel
Subject: bug#65673: [PATCH] Add lua-ts-mode
Date: Sun, 10 Sep 2023 14:57:30 +0200
User-agent: Gnus/5.13 (Gnus v5.13)

On Sun, 10 Sep 2023 at 11:12, Philip Kaludercic wrote:

> john muhl <jm@pub.pink> writes:
>> +(defcustom lua-ts-luacheck-program (executable-find "luacheck")
>
> It is better not to hard-code the path to lua during loading, in case
> the executable is moved around, since you will basically always still be
> querying PATH when starting a new process.
>
>> +  "Location of the Luacheck program."
>> +  :type '(choice (const nil) (file :must-match t))
>
> Which is why I think that this shouldn't be a file.
>> +(defcustom lua-ts-inferior-program (executable-find "lua")
>> +  "Program to run in the inferior Lua process."
>> +  :type '(choice (const nil) (file :must-match t))
>> +  :group 'lua
>> +  :version "30.1")
> Same here.

Good point, calling `executable-find' at this stage will also preclude
working over Tramp, among other potential issues.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]