bug#65673: [PATCH emacs 0/1] Add lua-ts-mode

[Mauro Aranda]

~johnmuhl <johnmuhl@git.sr.ht> writes:

I just have some comments/questions about the defcustoms:

> +(defcustom lua-ts-indent-offset 4
> +  "Number of spaces for each indentation step in `lua-ts-mode'."
> +  :type 'integer
> +  :safe 'integerp
> +  :group 'lua
> +  :version "30.1")

Does :type 'natnum fit better here?

> +(defcustom lua-ts-luacheck-program "luacheck"
> +  "Location of the Luacheck program."
> +  :type 'string
> +  :group 'lua
> +  :version "30.1")

I think :type 'file is better.

> +(defcustom inferior-lua-interpreter "lua"
> +  "Program to run in the inferior Lua process."
> +  :type 'string
> +  :safe 'stringp
> +  :group 'lua
> +  :version "30.1")

Same as above.

> +(defcustom inferior-lua-startfile ""
> +  "File to load into the inferior Lua process at startup."
> +  :type 'string
> +  :safe 'stringp
> +  :group 'lua
> +  :version "30.1")

Same as above, but maybe the default value should be changed to nil, to
indicate no startfile?