[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63513: [PATCH] Make persist-defvar work with records and hash tables
From: |
Ihor Radchenko |
Subject: |
bug#63513: [PATCH] Make persist-defvar work with records and hash tables |
Date: |
Sat, 09 Sep 2023 10:01:34 +0000 |
Joseph Turner <joseph@breatheoutbreathe.in> writes:
>> Then, wouldn't it be better to contribute this function to compat.el and
>> use it from there?
>
> The new behavior of copy-tree has already been added to compat.el:
>
> https://github.com/emacs-compat/compat/pull/25
>
> However, that change currently only exists in compat's emacs-30 branch.
I see.
> I did not know if it was acceptable for persist.el to require compat
> when I wrote these patches. If we agree that it is acceptable, then I'm
> happy to submit a patch to replace (persist-copy-tree ...) with
> (compat-call copy-tree ...), but we'll have to wait to apply the patch
> until after the compat.el emacs-30 branch is merged into master.
AFAIU, the recommended way to implement compat function definitions that
are not yet added to compat.el is using `compat-defun' + `compat-call'.
Then, one can simply drop `compat-defun' after the function is finally
release with compat.el without touching the rest of the code.
CCing Daniel.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, (continued)
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Joseph Turner, 2023/09/04
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Stefan Monnier, 2023/09/05
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Ihor Radchenko, 2023/09/08
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Eli Zaretskii, 2023/09/08
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Ihor Radchenko, 2023/09/08
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Eli Zaretskii, 2023/09/08
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Ihor Radchenko, 2023/09/08
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Stefan Monnier, 2023/09/08
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Ihor Radchenko, 2023/09/08
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Joseph Turner, 2023/09/08
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables,
Ihor Radchenko <=
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Daniel Mendler, 2023/09/09
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Ihor Radchenko, 2023/09/09
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Daniel Mendler, 2023/09/09
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, phillip . lord, 2023/09/05