[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63513: [PATCH] Make persist-defvar work with records and hash tables
From: |
Ihor Radchenko |
Subject: |
bug#63513: [PATCH] Make persist-defvar work with records and hash tables |
Date: |
Fri, 08 Sep 2023 17:06:10 +0000 |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>>> Here you go!
>>> Thanks, pushed!
>> May it be possible to promote `persist-hash-equal' and
>> `persist-copy-tree' to common subr.el functions?
>> The topic of comparing hash tables has been previously discussed in
>> https://yhetil.org/emacs-devel/871qvz4kdw.fsf@localhost/
>
> Hmm... AFAICT `persist-copy-tree` is a copy of our current `copy-tree`,
> so there's nothing to do there :-)
Err...
Then, wouldn't it be better to contribute this function to compat.el and
use it from there?
> As for `persist-hash-equal` (which is actually called `persist-equal`,
> AFAICT), I think if we want to move it out of `persist.el` we need to
> improve it so it also looks inside hash-tables that occur within
> vectors, conses, etc...
>
> Maybe, like Sam Steingold suggested, we should simply consider the
> current treatment of `equal` on hash-tables to be a bug.
That thread had no progress for quite a while.
I thought that having `hash-equal' function could at least be an
improvement (clearly, it is being used 🙂).
But if you have an idea how to move the original discussion forward,
please share it. AFAIU, no actionable conclusion have been reached in
the linked thread.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, (continued)
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Joseph Turner, 2023/09/04
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Stefan Monnier, 2023/09/04
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Joseph Turner, 2023/09/04
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Stefan Monnier, 2023/09/05
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Ihor Radchenko, 2023/09/08
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Eli Zaretskii, 2023/09/08
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Ihor Radchenko, 2023/09/08
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Eli Zaretskii, 2023/09/08
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Ihor Radchenko, 2023/09/08
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Stefan Monnier, 2023/09/08
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables,
Ihor Radchenko <=
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Joseph Turner, 2023/09/08
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Ihor Radchenko, 2023/09/09
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Daniel Mendler, 2023/09/09
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Ihor Radchenko, 2023/09/09
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, Daniel Mendler, 2023/09/09
- bug#63513: [PATCH] Make persist-defvar work with records and hash tables, phillip . lord, 2023/09/05