[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65726: 29.1.50; Crash in regexp engine
From: |
Stefan Monnier |
Subject: |
bug#65726: 29.1.50; Crash in regexp engine |
Date: |
Tue, 05 Sep 2023 09:08:01 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
> Thank you for fixing it, but now regex-emacs-tests fail with a regexp stack
> overflow.
Really? I thought I had specifically run that test.
[ ...recompiling + rerunning the test... ]
Hmm... you're right. Crap.
> It seems that by fixing this bug, we've unfixed the one that the
> broken code was supposed to fix.
Well, that one was less of a bug (more of a missing optimization), so
it's no reason to revert the change, but yes, not good.
Let's see if I can finagle something.
> And we should probably include a regression test for this bug as well.
> The previously mentioned
>
> (string-match (rx (* "a") (* (* "b"))) "a")
>
> might suffice, but extending it to
>
> (string-match (rx (* "a") (* (or "c" (* "b")))) "a")
>
> is safer in case the regexp compiler decides to simplify (* (* X)) -> (* X).
Feel free. To me, it feels too much like testing the presence/absence
of a very specific bug (i.e. too unlikely that we'll reintroduce that
exact bug. It's not like it was a weird case I didn't think of).
Stefan
- bug#65726: 29.1.50; Crash in regexp engine, martin rudalics, 2023/09/04
- bug#65726: 29.1.50; Crash in regexp engine, Mattias Engdegård, 2023/09/04
- bug#65726: 29.1.50; Crash in regexp engine, Eli Zaretskii, 2023/09/04
- bug#65726: 29.1.50; Crash in regexp engine, Mattias Engdegård, 2023/09/04
- bug#65726: 29.1.50; Crash in regexp engine, Mattias Engdegård, 2023/09/04
- bug#65726: 29.1.50; Crash in regexp engine, Eli Zaretskii, 2023/09/04
- bug#65726: 29.1.50; Crash in regexp engine, Mattias Engdegård, 2023/09/04
- bug#65726: 29.1.50; Crash in regexp engine, Mattias Engdegård, 2023/09/05
- bug#65726: 29.1.50; Crash in regexp engine,
Stefan Monnier <=
- bug#65726: 29.1.50; Crash in regexp engine, Mattias Engdegård, 2023/09/05
- bug#65726: 29.1.50; Crash in regexp engine, Stefan Monnier, 2023/09/05
- bug#65726: 29.1.50; Crash in regexp engine, Mattias Engdegård, 2023/09/06
- bug#65726: 29.1.50; Crash in regexp engine, Stefan Monnier, 2023/09/09
- bug#65726: 29.1.50; Crash in regexp engine, Mattias Engdegård, 2023/09/09
- bug#65726: 29.1.50; Crash in regexp engine, Stefan Monnier, 2023/09/14
- bug#65726: 29.1.50; Crash in regexp engine, Mattias Engdegård, 2023/09/15
- bug#65726: 29.1.50; Crash in regexp engine, Stefan Monnier, 2023/09/15
- bug#65726: 29.1.50; Crash in regexp engine, Stefan Monnier, 2023/09/15
- bug#65726: 29.1.50; Crash in regexp engine, Mattias Engdegård, 2023/09/16