[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items
From: |
Eli Zaretskii |
Subject: |
bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items |
Date: |
Sat, 02 Sep 2023 09:41:00 +0300 |
> Cc: 64440@debbugs.gnu.org, Manuel Giraud <manuel@ledu-giraud.fr>
> Date: Sat, 02 Sep 2023 08:44:16 +0800
> From: Po Lu via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> Stefan Kangas <stefankangas@gmail.com> writes:
>
> >> Here is a new set of patches with two more on top of the previous ones
> >> (ie. Number 1 and 2 should be the same as before).
> >>
> >> Number 3 sets the default mouse cursor to be an arrow on the default
> >> menu bar area. Number 4 fixes a flickering I had while moving the mouse
> >> pointer *into* a menu bar entry.
> >
> > Po Lu, do you have any comments on this patch series?
> >
> > Thanks in advance.
>
> Thanks. I don't understand why adjustments to note_tab_bar_highlight or
> note_tool_bar_highlight are warranted, and I think this ought to be
> optional.
>
> ChangeLog entries are also absent from the commit messages.
I'd appreciate a walkthrough of the patches with explanations for the
significant hunks. It's a non-trivial change, so I think the
rationale and the main ideas of the implementation should be described
and discussed.
I also have difficulty understanding comments like this one:
/* Clear mouse face but the mouse cursor. */
What does it try to say?
- bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items, Stefan Kangas, 2023/09/01
- bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items, Po Lu, 2023/09/01
- bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items,
Eli Zaretskii <=
- bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items, Manuel Giraud, 2023/09/02
- bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items, Manuel Giraud, 2023/09/05
- bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items, Eli Zaretskii, 2023/09/10
- bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items, Po Lu, 2023/09/10
- bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items, Manuel Giraud, 2023/09/11
- bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items, Eli Zaretskii, 2023/09/11
- bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items, Manuel Giraud, 2023/09/11
- bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items, Eli Zaretskii, 2023/09/11
- bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items, Manuel Giraud, 2023/09/11
- bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items, Eli Zaretskii, 2023/09/11