[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buff
From: |
Eli Zaretskii |
Subject: |
bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background' |
Date: |
Sun, 20 Aug 2023 11:50:04 +0300 |
> From: Lin Sun <sunlin7@yahoo.com>
> Date: Fri, 18 Aug 2023 19:03:08 +0000
> Cc: 65346@debbugs.gnu.org
>
> On Fri, Aug 18, 2023 at 5:52 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > This changes the API of a public function in incompatible ways, which
> > we try very hard not to do. Instead, the signature or
> > eww-open-in-new-buffer should be like this:
> >
> > (defun eww-open-in-new-buffer (&optional no-select)
> >
> > and the new NO-SELECT argument should be set non-nil by C-u.
> >
> > > + (user-error "No avaliable link")))
> >
> > This also changes the text of the error message in this case. Was
> > that really necessary? The original text was more accurate, I think.
> >
> > Also, this new feature needs a NEWS entry and a suitable addition to
> > the EWW manual.
>
> The attached patch included changes for the function, error message,
> NEWS and EWW manual.
> Please help review it.
Thanks, installed on master, and closing the bug.
Please in the future include a more detailed log of the changes in the
commit log message, and please follow our conventions for that as
described in CONTRIBUTE. I did it for you this time, but it required
quite a lot of manual work.
bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background', Michael Heerdegen, 2023/08/17