[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buff
From: |
Lin Sun |
Subject: |
bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background' |
Date: |
Fri, 18 Aug 2023 19:03:08 +0000 |
On Fri, Aug 18, 2023 at 5:52 AM Eli Zaretskii <eliz@gnu.org> wrote:
> This changes the API of a public function in incompatible ways, which
> we try very hard not to do. Instead, the signature or
> eww-open-in-new-buffer should be like this:
>
> (defun eww-open-in-new-buffer (&optional no-select)
>
> and the new NO-SELECT argument should be set non-nil by C-u.
>
> > + (user-error "No avaliable link")))
>
> This also changes the text of the error message in this case. Was
> that really necessary? The original text was more accurate, I think.
>
> Also, this new feature needs a NEWS entry and a suitable addition to
> the EWW manual.
The attached patch included changes for the function, error message,
NEWS and EWW manual.
Please help review it.
Thanks. Regards
0001-lisp-net-eww.el-eww-open-in-new-buffer-able-to-stay-.patch
Description: Text Data
bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background', Michael Heerdegen, 2023/08/17