bug#62694: 30.0.50; eglot-tests fails with recent pylsp

[João Távora]

On Thu, Apr 6, 2023 at 3:58 PM Michael Albinus <michael.albinus@gmx.de> wrote:
>
> João Távora <joaotavora@gmail.com> writes:
>
> Hi João,
>
> >> I disagree. Running regression tests towards bleeding edge development
> >> version of pylsp is not the intention. You cannot expect, that everybody
> >> running Emacs tests has installed pylsp like this. But she could have
> >> installed the Debian pylsp package.
> >
> > Sure, or she has a 'pylsp' that prints the complete works of
> > Shakespeare. But these tests are designed for the number one
> > recommended pylsp installation method. It's AFAIK not the
> > "bleeding edge" (which would be a Git installation). And tests
> > have been running fine with that installation method for a
> > number of months now, maybe even years.
>
> I don't doubt. But you cannot expect that everybody uses "the number one
> recommended pylsp installation method".

I expect that. The same way I expect people to install Eglot from ELPA, and
use a normal installation of Emacs, not some "Doom" or "Spacemacs". Or the
same way I expect people not to have advice in their configurations.
Many times my expectation fails, and yet I expect these things, because
that's what I programmed against.

So if they don't use that method, then maybe they should.  More
importantly, here we're  talking about the much smaller universe of Emacs
developers, not regular users.

> Again, I'm not speaking about eglot users. They shall know what to
> do. But eglot-tests could fail for everybody who has installed a pylsp
> package, for example from Debian, w/o even being interested in eglot.

That package is faulty to some degree in that it does not work exactly
like the recommended installation of pylsp.

Even if that's a problem for some hypothetical hardcore Debian
user who happens to also be an Emacs developer and who uses pylsp
but not in Eglot, and for some reason won't install anything from anywhere
else in his development machine, we have yet to hear from the hordes of
users at the intersection of all those conditions.

In your case in particular, I'd say you have control over what you
install in your machine and what you install in EMBA.  And I've
given you the recommended way to fix this, if you really must have
pylsp there.  Again, can you answer what is preventing you from using
`pip install` in your machine or in EMBA scripts?

Also, what is moving you so resolutely to install pylsp at all in EMBA?
Are you programming Python with some other LSP client on EMBA.  Is
anyone?

Are you just trying to get the best possible coverage from eglot-tests.el?
Thanks, but then I'd focus on rust-analyzer first, or the Java jdtls server.
The latter would be really useful as the GitHub CI isn't currently
installing it and the test is being skipped there.

> >> I recommend that you investigate why the tests fail. And if this sounds
> >> too much, at least the sanity checks shall be improved. (skip-unless
> >> (executable-find "pylsp")) doesn't seem to be sufficient then.
> >
> > I don't have Debian.  We can overhaul the sanity checks, but I don't
> > immediately see how.  Or why.  So it's hardly a priority.
>
> See above. With the instructions I have added to admin/notes/emba, it
> should be simple.

Thanks, I'll have a look one of these days.

João