[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58790: Eglot URI parsing bug when using clojure-lsp server
From: |
João Távora |
Subject: |
bug#58790: Eglot URI parsing bug when using clojure-lsp server |
Date: |
Thu, 10 Nov 2022 22:30:54 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Danny Freeman <danny@dfreeman.email> writes:
> João Távora <joaotavora@gmail.com> writes:
>
>> I agree on the two comments about the ChangeLog style entries and the
>> spacing.
>>
>> But when dealing with eglot.el, which I am the prime maintainer of,
>> I really prefer to see design described in the commit message where the
>> design was introduced. It plays very well with vc-region-history.
>>
>> So Danny, if you don't mind, please revert that part.
>>
>> João
>
> Yall all really taking me for a ride on this lol.
Sorry. The Emacs commit message format is a bit of work in the
beginning but it pays off in the end. I will make minor adjustment to
your patches and push them now.
> In reviewing the comments over and over I've made a modification to the
> second patch involving the warning message. Instead of using an
> arbitrary symbol I realized that the function `find-file-name-handler'
> works when a nil value for the second argument (operation).
OK, I will look at this part, too.
João
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, (continued)
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, João Távora, 2022/11/02
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/02
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/03
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Eli Zaretskii, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, João Távora, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Eli Zaretskii, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, João Távora, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server,
João Távora <=
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, João Távora, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Eli Zaretskii, 2022/11/11
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Michael Albinus, 2022/11/12
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/13
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Michael Albinus, 2022/11/15
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/15
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Michael Albinus, 2022/11/16
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, João Távora, 2022/11/16