bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#58790: Eglot URI parsing bug when using clojure-lsp server


From: Danny Freeman
Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server
Date: Thu, 10 Nov 2022 17:22:15 -0500

João Távora <joaotavora@gmail.com> writes:

> I agree on the two comments about the ChangeLog style entries and the
> spacing.  
>
> But when dealing with eglot.el, which I am the prime maintainer of, 
> I really prefer to see design described in the commit message where the 
> design was introduced. It plays very well with vc-region-history.
>
> So Danny, if you don't mind, please revert that part.  
>
> João

Yall all really taking me for a ride on this lol.

In reviewing the comments over and over I've made a modification to the
second patch involving the warning message. Instead of using an
arbitrary symbol I realized that the function `find-file-name-handler'
works when a nil value for the second argument (operation).

Anyways, here they are again.

Attachment: 0001-Eglot-Only-handle-URIs-with-the-file-scheme.patch
Description: Text Data

Attachment: 0002-Eglot-warn-when-receiving-a-non-file-scheme-URI.patch
Description: Text Data

-- 
Danny Freeman

reply via email to

[Prev in Thread] Current Thread [Next in Thread]