bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#58948: 29.0.50; Add :noquery to 'make-network-process' used by eglot


From: Juri Linkov
Subject: bug#58948: 29.0.50; Add :noquery to 'make-network-process' used by eglot
Date: Wed, 02 Nov 2022 20:22:52 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu)

close 58948 29.0.50
thanks

>     Juri> Tags: patch
>     Juri> Every time while exiting Emacs, an internal process is displayed and
>     Juri> asked whether to exit.
>
>     Juri> Eglot already uses `:noquery t' in two places for `make-process',
>     Juri> but can't use the same for `open-network-stream' because it's still 
> unhandled.
>     Juri> Here is the patch that adds it:
>
> I guess this is ok, although itʼs missing documentation and a commit
> message :-)

Thanks for reviewing, now pushed with doc changes.

> Iʼm even tempted to say that unrecognized keyword arguments should
> just be passed on to `make-network-process' as-is, but thatʼs a bigger
> and riskier change.

Agreed.  Maybe then more parameters of make-network-process
could be copied to open-network-stream manually one by one.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]