[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el
From: |
Theodor Thornhill |
Subject: |
bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el |
Date: |
Tue, 16 Jun 2020 13:29:19 +0000 |
Hello!
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
[...]
> Nit: For consistency with switch-to-buffer,
> this should be "Switch to buffer: " without the hyphens.
Yes, absolutely!
>> + (lambda (buffer)
>> + (when-let ((file (buffer-file-name (cdr buffer))))
>
> Nit: Neither the manual nor read-buffer's docstring documents what
> (cdr buffer) is here, so a comment mentioning Vbuffer_alist or something
> along those lines would be nice.
It kind of does, though indirectly? But sure, I can add a small comment.
Documentation states that:
"It will be called with each potential candidate, in the form of either a
string or a cons cell whose ‘car’ is a string, and should return non-nil to
accept the candidate for completion, nil otherwise."
[...]
> Otherwise LGTM, thanks,
Nice
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/15
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Philip K., 2020/06/15
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Dmitry Gutov, 2020/06/15
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/15
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Dmitry Gutov, 2020/06/15
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Philip K., 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Basil L. Contovounesios, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el,
Theodor Thornhill <=
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Basil L. Contovounesios, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Basil L. Contovounesios, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Basil L. Contovounesios, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Dmitry Gutov, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Dmitry Gutov, 2020/06/17
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Dmitry Gutov, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Basil L. Contovounesios, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Dmitry Gutov, 2020/06/16