[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el
From: |
Dmitry Gutov |
Subject: |
bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el |
Date: |
Tue, 16 Jun 2020 02:38:21 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
Thank you.
On 16.06.2020 01:05, Theodor Thornhill wrote:
What do you think?
A few more notes. :-)
> + "Switch-to-buffer: " nil nil
The REQUIRE-MATCH argument should be t, I think.
> + (lambda (buffer)
> + (when-let* ((path (buffer-file-name (cdr buffer)))
The word "path" is reserved for something else (e.g. exec-path) in the
GNU project.
Call it file or file-name.
> + (true (file-truename path)))
Do we need this conversion? It'll add some runtime overhead, and I'm not
sure in which conditions the result will be different.
> + (when (file-in-directory-p true (project-root pr))
> + 'buffer)))))))
Why 'buffer and not t?
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/15
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Philip K., 2020/06/15
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Dmitry Gutov, 2020/06/15
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/15
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el,
Dmitry Gutov <=
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Philip K., 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Basil L. Contovounesios, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Basil L. Contovounesios, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Basil L. Contovounesios, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Basil L. Contovounesios, 2020/06/16