bug#35062: [PATCH v3 1/3] Remove redundant comparison

[Konstantin Kharlamov]

В Пн, апр 15, 2019 at 18:21, Eli Zaretskii <eliz@gnu.org> 
написал:
> >  Date: Mon, 15 Apr 2019 18:01:35 +0300
> >  From: Konstantin Kharlamov <hi-angel@yandex.ru>
> >  Cc: rms@gnu.org, 35062@debbugs.gnu.org
> >
> >  > That's true, but this is not such a situation: the original 
> > changes
> >  > were never committed without any modifications.
> >
> >  Well, given the line my patch modifies has no changes, the only
> >  modification was the commit message. My only mistake was not knowing
> >  that UTF8 is prohibited. But really, it's a 2 symbols text 
> > replacement,
> >  me or you could just replace it.
>
> No, the log message was not the problem.  Look at the code changes,
> they were the ones I modified.

The line that I changed is exactly the same. What you did is cleaning 
up the function even further, however that didn't touch my 
modifications. Your modification is not strictly relevant to my patch.

> >  Is there an extra work? The changes you added can be commited with 
> > α)
> >  git commit --amend -v, or β) git commit -v. You did α, which only
> >  differs from β by a number of characters, that is ironically 
> > smaller
> >  in β.
>
> Yes, this is extra work: it requires one more commit.  More steps,
> more opportunities to make mistakes, etc.  And that's if I'm not
> interrupted in the middle of it by something in Real Life, or someone
> pushes to upstream in-between, and I need to pull again and perhaps
> resolve conflicts.  I'd rather avoid such complications for a simple
> job like that.

Okay, let's compare:

1. Doing extra commit:  "git commit"
2. Changing last commit "git commit --amend"

You did 2, do you see how 1 has less symbols?

What other extra steps did you take, writing the commit message? But 
since you rewrote mine anyway, this step you would take for either of 1 
and 2.