bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34621: [PATCH] Fix rgrep in dired taking default search file pattern


From: Christopher Thorne
Subject: bug#34621: [PATCH] Fix rgrep in dired taking default search file pattern from directory name (e.g. *.11 for django-1.11)
Date: Wed, 10 Apr 2019 11:42:50 +0100
User-agent: Roundcube Webmail/1.3.8

This is an overwhelmingly long name, please use the same name as
the function that uses this feature, i.e. just 'grep-read-files'.
Then when someone reading dired.el will find a line

  (put 'dired-mode 'grep-read-files 'dired-grep-read-files)

it will be clear for them the purpose of this feature.

Good point, I've changed it to grep-read-files.

Please place this change in dired.el after the definition of
'dired-file-name-at-point' that you can use in your dired function
instead of (run-hook-with-args-until-success 'file-name-at-point-functions)

Thanks, also done this.

If you want you could also add as a 4th option additionally
(run-hook-with-args-until-success 'file-name-at-point-functions)
to automatically support modes other than dired, i.e. other modes
that set file-name-at-point-functions.

Sounds like a sensible default, added this as well.

Patch attached.

Attachment: 0001-Fix-rgrep-in-dired-using-directory-for-search-file-p.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]