bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34621: [PATCH] Fix rgrep in dired taking default search file pattern


From: Noam Postavsky
Subject: bug#34621: [PATCH] Fix rgrep in dired taking default search file pattern from directory name (e.g. *.11 for django-1.11)
Date: Tue, 09 Apr 2019 07:52:24 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux)

> +  (let* ((file-name-at-point (run-hook-with-args-until-success
> 'file-name-at-point-functions))

Just a minor suggestion meta suggestion: post your patches by attaching
the output from 'git format-patch', rather than inlining the output of
git diff.  That will avoid patch corruption due to line-wrapping, like
in the above quote (although that line is also a bit long, and you
should break it manually).

> Changelog entry:
> * lisp/progmodes/grep.el (grep-read-files): Allow major modes to
> define file name to use for default search pattern
> * lisp/dired.el (dired-grep-file-name-for-default-pattern): Use file
> at point
> for grep file name pattern

And the ChangeLog entry then goes in the git commit message.  It's much
easier for other people to apply your patch that way.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]