bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions

[Konstantin Kharlamov]

On Пт, Apr 5, 2019 at 10:05, Eli Zaretskii <eliz@gnu.org> wrote:
> >  From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> >  Date: Tue,  2 Apr 2019 03:23:27 +0300
> >
> >  * src/gtkutil.c:
> >      remove "always false" comparison
> >      remove multiplication by zero, it's a noop anyway
> >      remove min_cols and min_rows as it's now unused
> >
> >  Fixes LGTM warnings:
> >      * Comparison is always false because min_cols <= 0.
> >      * Comparison is always false because min_rows <= 0.
> >  ---
> >  v2: remove the min_rows/min_cols whatsoever
>
> Thanks, pushed.  Please in the future write the commit log messages in
> the ChangeLog-like style, see CONTRIBUTE for the details.  I did that
> this time, you can look at what I pushed to see an example of that
> style in action.

Thanks, so, I'm looking right now to modify the rest of series and 
resend it here, and… I think I miss something: the only difference of 
my commit from CONTRIBUTE file is that I forgot to list the functions 
changed.

I think I misunderstand something, because you completely rewrote the 
commit messages compared to mine. Titles now are more vague, and for 
some reason you removed a note that one of patches fixes warnings in 
the code. And then you also added "Bug#35062", even though there's no 
bug (the report existence is incidental, it's because bugtracker is 
used to track patches in Emacs. But writing "Bug" will only confuse 
readers — there's no bug).