[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35062: [PATCH 3/4] min_cols/rows is always 0, don't check for it
From: |
Noam Postavsky |
Subject: |
bug#35062: [PATCH 3/4] min_cols/rows is always 0, don't check for it |
Date: |
Mon, 01 Apr 2019 18:37:15 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) |
Konstantin Kharlamov <Hi-Angel@yandex.ru> writes:
> * src/gtkutil.c: remove unnecessary comparison
> @@ -1401,7 +1401,7 @@ x_wm_set_size_hint (struct frame *f, long int flags,
> bool user_position)
> - int min_rows = 0, min_cols = 0;
> + const int min_rows = 0, min_cols = 0;
> - if (min_cols > 0) --min_cols; /* We used one col in base_width = ... 1); */
> - if (min_rows > 0) --min_rows; /* We used one row in base_height = ... 1);
> */
> -
> size_hints.base_width = base_width;
> size_hints.base_height = base_height;
> size_hints.min_width = base_width + min_cols * FRAME_COLUMN_WIDTH (f);
If min_cols is always 0, then what use is the
"+ min_cols * FRAME_COLUMN_WIDTH (f)"?
(and a similar question arises for min_cols and min_rows in
update_wm_hints of widget.c)
- bug#35062: [PATCH 3/4] min_cols/rows is always 0, don't check for it,
Noam Postavsky <=
- bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions, Konstantin Kharlamov, 2019/04/01
- bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions, Eli Zaretskii, 2019/04/05
- bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions, Konstantin Kharlamov, 2019/04/05
- bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions, Eli Zaretskii, 2019/04/06
- bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions, Konstantin Kharlamov, 2019/04/06
- bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions, Eli Zaretskii, 2019/04/06