[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#21072: Brave new mark-defun (and a testing tool)
From: |
Marcin Borkowski |
Subject: |
bug#21072: Brave new mark-defun (and a testing tool) |
Date: |
Fri, 12 May 2017 11:42:24 +0200 |
User-agent: |
mu4e 0.9.19; emacs 26.0.50 |
On 2017-05-10, at 04:53, npostavs@users.sourceforge.net wrote:
> Marcin Borkowski <mbork@mbork.pl> writes:
>
>> I finally found some time to make the branch nicer, deleted it from the
>> server and pushed the new one. Could you look at it one more time and
>> merge it to master (or greenlight me to do it)?
>
> [[c1c3403cf2]]
>> Fix Bug#21072 and rework `mark-defun'
>>
>> * test/lisp/progmodes/elisp-mode-tests.el (mark-defun-test-buffer):
>> New variable
>> (mark-defun-no-arg-region-inactive)
>> (mark-defun-no-arg-region-active)
>> (mark-defun-arg-region-active)
>> (mark-defun-pos-arg-region-inactive)
>
> There should be a colon after the close paren on each of those lines.
>
>> (mark-defun-neg-arg-region-inactive, mark-defun-bob): Add tests for
>> the new `mark-defun'
>>
>> * lisp/emacs-lisp/lisp.el (beginning-of-defun--in-emptyish-line-p):
>> New function
>> (beginning-of-defun-comments): New function
>> (mark-defun): Fix bug#21072, also rewrite large parts of `mark-defun'
>> to accept a numerical prefix argument
>
> There should be a period at the end of each entry.
>
> [[aeed45da]]
>> * lisp/emacs-lisp/lisp.el (mark-defun): simplify moving the point
>
> Missing capitalization and period (if you're not just squashing this).
>
>
> [[b8fd2c2ca1]]
>> * Fix elisp-tests-with-temp-buffer compilation
> [...]
>
> Please add to this the patch from
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21072#254.
>
> [[7efd2f2ea1]]
>> Modify `beginning-of-defun-comments'
>
> If you are keeping this one, I would add to the commit message:
>
> * lisp/emacs-lisp/lisp.el (beginning-of-defun-comments): Try not to stop
> in the middle of a multiline comment.
Thanks.
All done, branch deleted and pushed again. Hopefully it's ok now. (I'm
still learning to write commit messages...)
Best,
--
Marcin Borkowski
- bug#21072: Brave new mark-defun (and a testing tool), Marcin Borkowski, 2017/05/03
- bug#21072: Brave new mark-defun (and a testing tool), Marcin Borkowski, 2017/05/03
- bug#21072: Brave new mark-defun (and a testing tool), Marcin Borkowski, 2017/05/09
- bug#21072: Brave new mark-defun (and a testing tool),
Marcin Borkowski <=
- bug#21072: Brave new mark-defun (and a testing tool), npostavs, 2017/05/12
- bug#21072: Brave new mark-defun (and a testing tool), Marcin Borkowski, 2017/05/14
- bug#21072: Brave new mark-defun (and a testing tool), Glenn Morris, 2017/05/14
- bug#21072: Brave new mark-defun (and a testing tool), npostavs, 2017/05/16
- bug#21072: Brave new mark-defun (and a testing tool), npostavs, 2017/05/20